clockworklabs / clockworklabs/SpacetimeDB
Procedure HTTP API: review and revise convenience methods on `Body`
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 25.2k
- Forks
- 1.1k
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 46
Description
See https://github.com/clockworklabs/SpacetimeDB/pull/3766#discussion_r2562947160 .
It's unfortunate that all of our methods on Body (e.g. into_string, into_bytes, into_string_lossy) take self owned, meaning you can't effectively pull data out of the http::Request<Body> without calling either into_parts or into_body. We should revise some or all of these methods to take &self receivers, or add new methods which take &self receivers additionally.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Body convenience methods mentioned in the issue, including into_string, into_bytes, and into_string_lossy, and read the linked pull request discussion. Determine which methods should borrow or whether additional borrowed methods are needed; done means the API supports reading from http::Request<Body> without consuming it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100