clockworklabs / clockworklabs/SpacetimeDB
Fix client behavior on `client_connected` rejection to ensure that all SDKs (and the server) treat a rejection as an `on_connect` error
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 25.2k
- Forks
- 1.1k
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 46
Description
Currently this behavior is undefined on the clients, but people may reasonably want to know that their client has been rejected by the server. "
Definition of Done
The DoD would be that in all SDKs returning an error or throwing an exception in client_connected should result in an on_connect_error on the client SDK which includes the error message from the client_connected reducer.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating client_connected handling in each SDK and on the server, then trace how a returned error or thrown exception is propagated. Done means every SDK emits on_connect_error with the client_connected reducer's error message when the server rejects the connection.
Written by the indexing model from the issue text.
Assessment
- Domain
- api, backend-api-design
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100