clockworklabs / clockworklabs/SpacetimeDB

PrimaryKey implementation should use client side indexes

Open
#2,113 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
25.2k
Forks
1.1k
Avg merge
2d 7h
Merged PRs (30d)
46

Description

Right now clients determine if rows match by calling a primary key compare func which just compares values in AlgebraicValue. Once we have client side indexes, we should just lookup the new value using the index to determine whether or not the current insert was an update.

Done for C# but not Typescript, Rust, Python

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing C# PrimaryKey implementation and the client-side index behavior described in the issue. Compare the Typescript, Rust, and Python client implementations to identify where primary-key comparisons still use AlgebraicValue. Done means those three clients use the client-side index consistently with the completed C# work, with relevant tests passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, python, rust, typescript
Domain
databases
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.