clockworklabs / clockworklabs/SpacetimeDB
Consider adding `RowRefMut<'_>` to reduce the amount of `unsafe`
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 25.2k
- Forks
- 1.1k
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 46
Description
To maintain sanity, we need to keep the growing amount of unsafe { ... } in table.rs under control. Consider adding a RowRefMut<'_> type to at least remove some get_row_ref_unchecked imposed by the borrow checker.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading table.rs and tracing the uses of get_row_ref_unchecked. Investigate whether a RowRefMut<'_> abstraction can remove some of the unsafe blocks while preserving the existing borrow relationships. Done means the relevant unsafe usage is reduced without changing table behavior; the issue names no tests, so identify the affected coverage while researching.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100