clockworklabs / clockworklabs/SpacetimeDB

CLI - Config-modifying commands print the "saving config" text twice

Open
#1,762 0 comments 0 reactions 1 assignee View on GitHub

@bfops is already working on this.

Since Sep 30, 2024.

Dominant language
Rust
Stars
25.2k
Forks
1.1k
Avg merge
2d 7h
Merged PRs (30d)
46

Description

Background

Commands like spacetime server set-default print the "Saving config" text twice.

This is because all commands save the config once right after loading it. (So this issue likely applies to all commands that actually modify the config).

Definition of Done

  • Stop saving the config unconditionally; only save when we actually make changes
    • including if the file wasn't found

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.