clockworklabs / clockworklabs/SpacetimeDB

Conversion from new ModuleDef -> existing TableSchema

Open
#1,628 0 comments 0 reactions 1 assignee View on GitHub

@kazimuth is already working on this.

Since Aug 23, 2024.

Dominant language
Rust
Stars
25.2k
Forks
1.1k
Avg merge
2d 7h
Merged PRs (30d)
46

Description

This will allow using the new ModuleDef validation code wherever we ingest RawModuleDefs and convert them to TableSchema etc in the codebase.

Requires an integration test that the following paths:

old: RawModuleDefV8 -> Vec<TableSchema>
new: RawModuleDefV8 -> RawModuleDefV9 -> ModuleDef -> Result<Vec<TableSchema>>

produce equivalent output (identical results, unless the new path rejects something that the old path accepts).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.