clj-commons / clj-commons/metrics-clojure
Make it possible to add password protection to expose-metrics-as-json
- Dominant language
- Clojure
- Stars
- 349
- Forks
- 80
- PR merge metrics
- No merged PRs in 30d
Description
The documentation for the ring extras says "WARNING: this URL will not be protected by a username or password in any way (yet), so if you have sensitive metrics you might want to think twice about using it (or protect it yourself)."
IMHO, the easiest way for adding password protection myself would be to add a route to composure that reads like
```
(GET "/metrics" [] (with-admin-privileges metrics-json))
```
instead of expose-metrics-as-json (where with-admin-privileges would ensure protection). But for this, "metrics-json" from the ring extras would have to be public. Can you make this method public so I can define the routes myself? Or did I misunderstand / miss something here?
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.