clj-commons / clj-commons/metrics-clojure

Add a way to uninstrument JVM metrics

Open
#109 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Clojure
Stars
349
Forks
80
PR merge metrics
No merged PRs in 30d

Description

If I call `metrics.jvm.core/instrument-jvm` during startup, there is no corresponding `metrics.jvm.core/uninstrument-jvm` to call during shutdown. This causes problems for me during tests that check startup and shutdown behavior; if I call `instrument-jvm` twice I get an error "A metric named jvm.attribute.vendor already exists".

I suppose a less desirable alternative that would still address my use-case would be to make instrumentation idempotent. A clean shutdown would be my preference.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.