clj-commons / clj-commons/aleph
HTTP Client: Disable Name Resolution in Proxy Mode
- Dominant language
- Clojure
- Stars
- 2.6k
- Forks
- 242
- Avg merge
- 4d 5h
- Merged PRs (30d)
- 1
Description
When going though a proxy, local name resolution isn't necessary, because the full URL is send to the proxy.
If I set only `:proxy-options` in `:connection-options` while creating a `connection-pool`, Netty is still resolving the remote address without any need.
Setting, in addition to `:proxy-options`, `:name-resolver` to `:noop`, solves the problem.
It might be a good idea to do this by default. But I may also overlook something here.
Contributor guide
Research direction
Start by tracing connection-pool handling of :proxy-options and :name-resolver, then inspect how Netty resolves the remote address in proxy mode. Determine whether disabling local resolution by default is safe, and document or test the expected behavior before considering the issue done.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- clojure
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100