'Thread' object has no attribute 'isAlive'
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 8.9k
- Forks
- 1.6k
- PR merge metrics
- No merged PRs in 30d
Description
Hi!
In "/usr/local/lib/python3.9/site-packages/pattern/web/init.py" we have isAlive() in line 224. Running the asynchronous requests example from pattern web it throws:
Traceback (most recent call last):
File "/Users/eyoshi/Python/Pattern/pattern_web_example.py", line 20, in
while not request.done:
File "/usr/local/lib/python3.9/site-packages/pattern/web/init.py", line 224, in done
return not self._thread.isAlive()
AttributeError: 'Thread' object has no attribute 'isAlive'
isAlive needs to be changed to is_alive() here.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open pattern/web/init.py and inspect the done property around line 224, then run the asynchronous requests example described in the issue. Update the outdated thread method and verify that request completion no longer raises AttributeError.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100