clips / clips/pattern

Verb mood is incorrect in tenses(verb)

Open
#229 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
8.9k
Forks
1.6k
PR merge metrics
No merged PRs in 30d

Description

Take the verb 'were' for example. If I do tenses('were') the list of possible tenses includes ('past', 3, 'singular', 'indicative', 'imperfective').

Certainly though,
He were correct.
is incorrect! It should be 'He was correct.

That said,
If he were correct, I'd be a monkey's uncle.
Is correct.

What changed? The MOOD. The second is conditional/subjunctive. My result then for tenses('were') should include ('past', 3, 'singular', 'subjunctive', 'imperfective') and ('past', 3, 'singular', 'conditional', 'imperfective') but it should not include ('past', 3, 'singular', 'indicative', 'imperfective').

This bug applies to conjugate(VERB) also. conjugate('was', 'present', 3, 'singular', 'conditional', 'imperfective') returns nothing, when instead it should return 'were'.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Python entry points tenses('were') and conjugate(...), tracing how mood is inferred and how conjugation handles conditional and subjunctive forms. Use the examples in the report as regression cases: indicative singular 'were' should be excluded, while subjunctive and conditional forms should be represented and conjugate should return 'were'.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.