clientIO / clientIO/joint

dia.CellView: `removeAttr()` does not remove the attribute from the root element

Open
#950 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
5.4k
Forks
893
Avg merge
3d 3h
Merged PRs (30d)
26

Description

element.attr('root/test', true);
element.removeAttr('root/test');
// element.findView(paper).el.getAttribute('test') === 'true';

Workaround:

element.attr('root/test', null);
// element.findView(paper).el.hasAttribute('test') === false;

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the JavaScript snippet with element.attr(), element.removeAttr(), and element.findView(paper), comparing the root element's test attribute with the null workaround. Trace the root attribute handling from these entry points. Done means removeAttr('root/test') makes hasAttribute('test') false, matching the workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.