Smart routers: Ends of the route are offset by a `step` away from padding box
Open
Nobody has claimed this yet.
bug
- Dominant language
- JavaScript
- Stars
- 5.4k
- Forks
- 893
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 26
Description
Both the manhattan and metro routers receive an extra offset at the beginning/end of the route (as large as one step unit). This is on top of any padding specified.
The offset is added by the getRectPoint function because of the way we use the config.directions array to control turns in the route.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing getRectPoint and the config.directions handling in the manhattan and metro routers. Verify how route endpoints are calculated, then confirm that both ends align with the padding box without an additional step-sized offset.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100