cli / cli/cli

Implement proper waiting for kwallet authentication

Open
#11,005 8 comments 0 reactions 0 assignees View on GitHub
enhancement gh-auth needs-investigation
Dominant language
Go
Stars
46.3k
Forks
9k
Avg merge
2d 9h
Merged PRs (30d)
89

Description

### Describe the feature or problem you’d like to solve

When using gh cli after the kwallet has closed I need to type the password for opening it again.
For all applications I've used until this cli, the application simply waits until the wallet have either been opened or the request have been canceled.

With the gh cli it fail in what feels like 5 seconds - at least not enough for me to type the password.
This means that each time my wallet has closed I call the same command twice, once for opening the wallet and then failing the command and once for running the command.

### Proposed solution

To have a way longer timeout, it doesn't have to be infinite but I think it has to be longer than seconds.
I think that most people won't be able to type the password in this short duration and I think 5 minutes should suffice.

### Additional context

The flow I'm going through each time the wallet has closed:

```bash
$ gh repo view --web
HTTP 401: This endpoint requires you to be authenticated. (https://api.github.com/graphql)
Try authenticating with: gh auth login
(1) $ gh repo view --web
Opening https://github.com/... in your browser.
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.