clerk / clerk/clerk-sdk-python
BUG: new clerk.enterprise_connections.create returns `Unset()` instead of empty values
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 186
- Forks
- 47
- Avg merge
- 18h 43m
- Merged PRs (30d)
- 1
Description
We just upgrade our Python SDK to the latest and migrate our previous clerk.saml_connections.create to clerk.enterprise_connections.create and returned the success response to our UI.
After the migration our UI was showing some strange values for idp_sso_url and idp_entity_id: ~?~unset~?~sentinel~?~
After a quick debug I noticed the return from the new enterprise connection method is:
id='samlc_...', name='ASDF - Microsoft', idp_entity_id=Unset(), idp_sso_url=Unset(), idp_metadata_url=Unset(), ...
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing clerk.enterprise_connections.create and inspect its returned fields, then compare the result with clerk.saml_connections.create. The fix is complete when idp_sso_url and idp_entity_id no longer expose Unset() or its sentinel to callers and the response provides the expected empty values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100