clementwzk / clementwzk/OpenCalc
issues with release v3.2.0
- Dominant language
- Kotlin
- Stars
- 1.5k
- Forks
- 186
- PR merge metrics
- No merged PRs in 30d
Description
There are some issues with your current v3.2.0 release: while the tag points to the proper commit, the APK attached to it was built from one commit behind – and thus identifies as `3.1.4 (52)`. Which is the same the previous release claims to be, so Android would not consider it an update.
Funny thing: building it directly from `e40169a91a64d606d07a1d22682ab15be7d9833d`, the APK is not reproducible due to differences in `AndroidManifex.xml`. Using `5910082ccf19a66d9d78456d2867ee70081a0b5c` and performing a `git reset` to the other commit, Manifest is OK but the differences move to `classes.dex`. So we cannot even reproduce the APK you've attached there…
`classes.dex`:
```diff
|: invoke-virtual {v1, v2}, Ljava/lang/StringBuilder;.append:(Ljava/lang/String;)Ljava/lang/StringBuilder;
-|: const-string v2, " 3.1.4 (52)"
+|: const-string v2, " 3.2.0 (53)"
|: invoke-virtual {v1, v2}, Ljava/lang/StringBuilder;.append:(Ljava/lang/String;)Ljava/lang/StringBuilder;
```
Manifest:
```
XML ELEM START [lineno=2, name='manifest', #attributes=7]
- ATTR: http://schemas.android.com/apk/res/android:versionCode=53
- ATTR: http://schemas.android.com/apk/res/android:versionName='3.2.0'
+ ATTR: http://schemas.android.com/apk/res/android:versionCode=52
+ ATTR: http://schemas.android.com/apk/res/android:versionName='3.1.4'
ATTR: http://schemas.android.com/apk/res/android:compileSdkVersion=34
```
Looks like you've built from a "dirty tree" somewhere in between…
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the v3.2.0 tag, the two referenced commits, and the attached APK; compare the generated AndroidManifex.xml and classes.dex outputs. Trace how the release build selects the commit and version metadata. Done means the release APK is reproducible and identifies as 3.2.0 (53), rather than 3.1.4 (52).
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- build-system, mobile, release
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100