clegaspi / clegaspi/saml_reader

Rewrite HarParser to parse in constructor

Open
#36 0 comments 0 reactions 0 assignees View on GitHub
code hygiene
Dominant language
Python
Stars
6
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Currently, the `HarParser` class requires the object be instantiated and parsed separately:

```python
raw_saml = HarParser(json_str).parse()
```

It would be nice to change this so that parsing happens in the constructor and a function is called to get the SAML data.

```python
raw_saml = HarParser(json_str).get_raw_saml_response()
```

This will make it more consistent with the other classes.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.