clegaspi / clegaspi/saml_reader

Add OR to graph suite test dependencies

Open
#30 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
6
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Right now all dependencies for a TestDefinition are applied with an AND scheme, as in all of the test dependencies need to be met before the test will run. Can we figure out how to do an OR?

For example, I had to code an additional test seeing if all required claim attributes were present, which basically re-tested the independent tests for the required attributes one by one. I could have achieved what I wanted to do if I could have had an OR dependence for the individual tests.

Might not be worth it in this instance, but just a thought. I was thinking that you could do a list of lists and the elements of the outer list are OR'd and the elements in the inner lists are AND'd.

`[ [(a, TEST_PASS), (b, TEST_FAIL)], [(c, TEST_FAIL)] ]`

Test will run if:
- `a` passes AND `b` fails
OR
- `c` fails

i.e. `( a & !b ) | !c`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.