clearlydefined / clearlydefined/service

"removeDefinitions" vs. "removedDefinitions"

Open
#664 7 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
TypeScript
Stars
51
Forks
46
PR merge metrics
No merged PRs in 30d

Description

While the schema has "removedDefinitions" (past tense, with "d"):

https://github.com/clearlydefined/service/blob/70b5362d448ec16e4b21a0ffabf57ab93f5d0701/schemas/swagger.yaml#L96-L97

The test code has "removeDefinitions" (imperative):

https://github.com/clearlydefined/service/blob/70b5362d448ec16e4b21a0ffabf57ab93f5d0701/test/providers/curation/github.js#L147

I guess this is again a case where the schema is wrong.

BTW: Is somewhere documented what setting `removeDefinitions` to `true` does *exactly*? I can guess from the name that is removes past contribution patches, but does it remove *all* of them? Or just the latest one? Or can we limit the removal to particular revisions?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.