clauderic / clauderic/react-sortable-hoc

Move onDrop clearup work to callback if provided

Open
#743 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
10.9k
Forks
959
PR merge metrics
No merged PRs in 30d

Description

when we drag an item to a new position it will fly back to original place if no onSortEnd function provided. this is reasonable and good. with onSortEnd function provided it will move to new position as the result of react reconciling.
in my case my page is a little bit too complex and need a while to rerender so that I will see that the dropped item will fly back to original place and then move to new position later on. this is not a perfect animation for complex page.
it will be perfect if we can control the timing of "fly back". I would suggest to move clearup work after line 946 (__this.helper.parentNode.removeChild(_this.helper)_) on react-sortable-hoc.esm.js to a callback function if user provided.
can this possible?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.