clauderic / clauderic/react-native-highlight-words

Update the package to use deprecated-react-native-prop-types and keep compatibility with react native 0.69.x

Open
#29 1 comment 3 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
205
Forks
74
PR merge metrics
No merged PRs in 30d

Description

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used [patch-package](https://github.com/ds300/patch-package) to patch `react-native-highlight-words@1.0.1` for the project I'm working on.

This package stopped working after upgrading react native to 0.69 due to ViewPropTypes being deprecated and removed from react native. Updating the package to use "deprecated-react-native-prop-types" resolved the issue.

Here is the diff that solved my problem:

```diff
diff --git a/node_modules/react-native-highlight-words/index.js b/node_modules/react-native-highlight-words/index.js
index e15cc90..4dab0dc 100644
--- a/node_modules/react-native-highlight-words/index.js
+++ b/node_modules/react-native-highlight-words/index.js
@@ -2,14 +2,15 @@ import React from 'react';
import {Text} from 'react-native';
import {findAll} from 'highlight-words-core';
import PropTypes from 'prop-types';
+import { TextPropTypes} from 'deprecated-react-native-prop-types';

Highlighter.propTypes = {
autoEscape: PropTypes.bool,
- highlightStyle: Text.propTypes.style,
+ highlightStyle: TextPropTypes.style,
searchWords: PropTypes.arrayOf(PropTypes.string).isRequired,
textToHighlight: PropTypes.string.isRequired,
sanitize: PropTypes.func,
- style: Text.propTypes.style
+ style: TextPropTypes.style
};

/**
```

This issue body was [partially generated by patch-package](https://github.com/ds300/patch-package/issues/296).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.