classtranscribe / classtranscribe/FrontEnd

Remove legacy dvajs ; unblock react update

Open
#768 5 comments 0 reactions 3 assignees Claimed by @harsh183 View on GitHub
Dominant language
JavaScript
Stars
24
Forks
29
PR merge metrics
No merged PRs in 30d

Description

dvajs is legacy, unmaintained, poorly documented and preventing us from moving to a more recent react version. It is likely that modern react components mean we don't need it.

We are using it for routing, history, and redux connect. However there are warnings in the browser console that are likely from dva -

```txt
Warning: Please use `require("history").createHashHistory` instead of `require("history/createHashHistory")`. Support for the latter will be removed in the next major release.

Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move code with side effects to componentDidMount, and set initial state in the constructor.
* Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: Route, Router, Switch
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.