Bug in collecting counts?
Open
- Dominant language
- C++
- Stars
- 768
- Forks
- 164
- PR merge metrics
- No merged PRs in 30d
Description
shouldn't line 225 use j+1 instead of j?
```
emp_feat += DiagonalAlignment::Feature(j, i, trg.size(), src.size()) * p;
```
in the surrounding loops, i ranges from 1 to src.size() inclusive and j from 0 to trg.size() exclusive. Further up in the code, j+1 is used as well, and I think the feature calculation assumes the same.
This bug would bias it towards a flatter distribution I think, but I'm not sure.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.