clab / clab/dynet

`model.c` doesn't provide definition for `ParameterCollection(float weight_decay_lambda);`

Open
#1,428 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
3.4k
Forks
701
PR merge metrics
No merged PRs in 30d

Description

In the header file `model.h`, there is a method declaration:
```c
ParameterCollection(float weight_decay_lambda);
```
But it seems that it has no corresponding implementation in `model.c`.
Instead,
```c
ParameterCollection::ParameterCollection(const string & my_name, ParameterCollection* my_parent, float weight_decay_lambda) :
name(my_name), storage(new ParameterCollectionStorage(weight_decay_lambda)), parent(my_parent) { }
```
is provided.

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect the ParameterCollection declarations in model.h and the existing definitions in model.c, starting with the constructor signatures shown in the issue. Check how the weight_decay_lambda value is expected to be handled, then verify that the declaration and implementation agree and that the project builds and its relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
machine-learning
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.