clab / clab/dynet

"empty" RNNStates should be rigged to return zero vectors on .s(), .h(), etc

Open
#1,322 2 comments 0 reactions 0 assignees View on GitHub
good first issue minor bug
Dominant language
C++
Stars
3.4k
Forks
701
PR merge metrics
No merged PRs in 30d

Description

having .s() return nothing on an RNN's initial state is very confusing (at least to me), as there must be some kind of value from which the RNN starts and not revealing it just hides what's going on (making things like automaton-extraction very difficult).

to my understanding, RNNStates with empty .s() are effectively treated as having zero-vectors in .add_input() computations (the matrix multiplication with the missing c/h vectors is simply skipped). It would be nice if .s(), .h(), .output(), etc reflected this.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.