clab / clab/dynet

Property setting syntax not supported for old (yet common) versions of cython

Open
#1,175 0 comments 0 reactions 0 assignees View on GitHub
minor bug
Dominant language
C++
Stars
3.4k
Forks
701
PR merge metrics
No merged PRs in 30d

Description

https://github.com/clab/dynet/blob/a094a592205cffb6091dbca90362abb488bd1e10/python/_dynet.pyx#L5582

The use of properties is not well supported in older cython versions.

We should support also method-based setter.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at python/_dynet.pyx around line 5582 and inspect how the property setter is declared. Check the surrounding API to determine the method-based setter form needed for older Cython versions. Done means the setter remains usable with those versions without relying on unsupported property-setting syntax.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.