ckan / ckan/datapusher

do not strip header value when type datetime.

Open
#63 1 comment 0 reactions 1 assignee Claimed by @wardi View on GitHub
Dominant language
Python
Stars
82
Forks
157
PR merge metrics
No merged PRs in 30d

Description

A bit of an edge case, but thought I'd put it here anyway.

When an .xls has a column header that is a properly formatted date, it is imported as datetime.datetime. Datapusher will try to strip the value, causing the below exception:

Offending file: https://dl.dropboxusercontent.com/u/6526141/cap180201.xls (second sheet in the excel file)

Trace:

```
Job "push_to_datastore (trigger: RunTriggerNow, run = True, next run at: None)" raised an exception
Traceback (most recent call last):
File "/Users/dz/Envs/datapusher/lib/python2.7/site-packages/apscheduler/scheduler.py", line 512, in _run_job
retval = job.func(*job.args, **job.kwargs)
File "/Users/dz/source/datapusher/datapusher/jobs.py", line 346, in push_to_datastore
headers = [header.strip() for header in headers if header.strip()]
AttributeError: 'datetime.datetime' object has no attribute 'strip'
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.