ckan / ckan/datapusher

Does not support resource with FTP URL-s

Open
#188 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
82
Forks
157
PR merge metrics
No merged PRs in 30d

Description

Disclaimer: I did **not** verify this issue (I assume a change equivalent to one made for pip had a result equivalent to [the one for pip](https://github.com/pypa/pip/issues/1532)).

DataPusher 0.0.6 supported loading resources over FTP. However, this seems to be no longer the case starting from 0.0.13, after commit 461019713b2e48e20b32df4fe37ac5907cc07edf, which stopped DataPusher from using urllib2 to use [the "Requests: HTTP for Humans" library](https://requests.readthedocs.io/en/master/), which - unsurprisingly - [only supports HTTP](https://github.com/psf/requests/issues/1237), as it is based on [urllib3](https://urllib3.readthedocs.io/en/latest/), which - despite its name - [does not support FTP](https://stackoverflow.com/questions/50392066/download-ftp-file-with-urllib3) like urllib2 did.

I'm filing this to document the change but also so that the code can be cleaned up. The error message for unsupported schemes ("Only http, https, and ftp resources may be fetched.") has not changed and suggests that FTP resources are still supported.

Note that [DataPusher's alternative xloader does not support FTP any more](https://github.com/ckan/ckanext-xloader/issues/107).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.