ckan / ckan/ckanext-validation

Bad shell return code after "Validation tables already exist"

Open
#44 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
30
Forks
33
PR merge metrics
No merged PRs in 30d

Description

When the paster `init-db` command finds that the validation tables already exist, it returns a shell exit code of 1, indicating failure. However, since the command appears to otherwise be idempotent, this isn't really a failure. The desired end state has been achieved.

This exit code causes problems when the paster command is being run as part of a larger system, like a Chef cookbook. It has to be caught and handled every time to stop the cookbook exiting due to the presumed error.

If it's desirable to *detect* whether the tables already exist, perhaps there could instead be a separate paster command for this?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.