ckan / ckan/ckanext-scheming

Failures against master because of OneOf changes

Open
#235 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
102
Forks
182
PR merge metrics
No merged PRs in 30d

Description

The OneOf validator was changed in https://github.com/ckan/ckan/pull/5060 to replace the formencode one, but the output when there is a validation error is slightly different:

```
New: u"Value must be one of [u'bactrian', u'hybrid', u'f2hybrid', u'snowwhite', u'black']"

Old "Value must be one of: bactrian; hybrid; f2hybrid; snowwhite; black (not 'rocker')"
```

This causes the validation tests errors for sure, I'm not sure about the form functional tests but they could also be related

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the validation tests mentioned in the issue, then inspect the related form functional tests to identify assertions affected by the OneOf message change. Compare their expected output with the old and new examples, and consider the work complete when the relevant test failures are resolved consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.