ckan / ckan/ckanext-googleanalytics

Extension does not respect custom uploader implementations

Open
#16 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
36
Forks
84
PR merge metrics
No merged PRs in 30d

Description

[ckanext--s3filestore](https://github.com/okfn/ckanext-s3filestore) implements a custom uploader and downloader, [overriding](https://github.com/okfn/ckanext-s3filestore/blob/master/ckanext/s3filestore/plugin.py#L57) the core download endpoint. ckanext-googleanalytics does the same, to register the download and [calls the core download action](https://github.com/ckan/ckanext-googleanalytics/blob/master/ckanext/googleanalytics/controller.py#L142) from the package controller afterwards.

So if you load the `googleanalytics` before the `s3filestore` one, your downloads return 404, because the core filesystem filestore is being called:

```
ckan.plugins = ... googleanalytics s3filestore # Does not work
```

Loading `googleanalytics` last works:

```
ckan.plugins = ... s3filestore googleanalytics # Works
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.