cityofaustin / cityofaustin/techstack

Wagtail 2.10.0 Upgrade + RichText Buttons

Open
#4,791 0 comments 0 reactions 0 assignees View on GitHub
CyberSecurity & Vulnerabilities Joplin Alpha Team: Dev
Dominant language
No language data
Stars
11
Forks
3
PR merge metrics
No merged PRs in 30d

Description

We need to upgrade to Wagtail 2.10.0! We don't want to fall behind when there's a major security update. But right now we've got 1 known blocker preventing us from upgrading Wagtail.

![Screen Shot 2020-08-12 at 4.12.26 PM.png](https://images.zenhubusercontent.com/5b9fcb6c68df0477b25368b3/d83517a6-53d1-45eb-aedc-4739da8c5047)

Button SVGs don't show up on the RichText editor. This is problem unique to our deployment.

I upgrading our odd-tail-bakery to v2.10.0. Admin password is in 1password
https://odd-tail-bakery.herokuapp.com/admin/pages/76/edit/

![Screen Shot 2020-08-12 at 4.13.46 PM.png](https://images.zenhubusercontent.com/5b9fcb6c68df0477b25368b3/bd3b91e7-f942-49fc-98e8-8fdc9983a165)

All the buttons work there.

So what happens on normal installations (like the bakery demo) is that an svg is rendered inside of the #shadow-root like so:
![Screen Shot 2020-08-12 at 4.14.14 PM.png](https://images.zenhubusercontent.com/5b9fcb6c68df0477b25368b3/9964d612-e518-4755-9939-f4fb287c3b29)

But on our site, we don't get that:
![Screen Shot 2020-08-12 at 4.16.09 PM.png](https://images.zenhubusercontent.com/5b9fcb6c68df0477b25368b3/d97e3ef5-22cb-4ab1-9120-3cd4ed97bfa0)

This only happens on Wagtail v2.10.0, not on version 2.9.3.

What could have happened? The only package that Wagtail upgraded was react-streamfield from v0.9.5 to v0.9.6. It's a big old mystery. That's why I'm making this a separate issue.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.