cityofaustin / cityofaustin/techstack
Publisher must handle subsequent PR builds from different "joplin" sources
- Dominant language
- No language data
- Stars
- 11
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
### As a [Content Author] I want [publisher to trigger an "all_pages" rebuild if my publish REQuest uses a different "joplin" from the last build] so that [my PR build doesn't break].
**Is your feature request related to a problem? Please describe.**
A Janis PR could potentially have build requests from multiple joplin instances. As @briaguya pointed out, we'd need to do an "all_pages" rebuild rather than an "incremental" build if a BLD is running off of a different joplin instance than the previous BLD.
**Describe the solution you'd like**
Within "process_new_build.sh", Publisher should check that the last BLD for a "janis_branch" used the same "joplin" as the new BLD will. If not, then the new BLD must then be converted to a "all_pages" build if and only if it was an "incremental" build_type previously. If its a "rebuild" build_type, then we would not want to downgrade that to an "all_pages" build.
**Describe alternatives you've considered**
It's an edgecase that we won't see problems with yet (since right now all builds are "all_pages" builds). And it would only affect PR environments. But we should do it in order to make our publisher bulletproof and have a seamless experience for our QA and testers.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.