citusdata / citusdata/the-process
Switch to quilt for PGDG package modifications
- Dominant language
- Dockerfile
- Stars
- 6
- Forks
- 7
- Avg merge
- 4d 22h
- Merged PRs (30d)
- 1
Description
[`build-pgdebs`](https://github.com/citusdata/the-process/blob/be26e475313e39e96f6380872f0e9cc7cb38b6db/circleci/images/debbuilder/files/build-pgdebs) makes several modifications to the base PGDG PostgreSQL packages in order to ensure the isolation tester, vanilla tests, `regress.so`, etc. are all in place at test-time. While it's OK to script changes to files within the `debian` subdirectory, edits of the source code itself really should be performed with [`quilt`](https://wiki.debian.org/UsingQuilt).
The following PostgreSQL source modifications should be performed using quilt patches:
* _Fix test install directory for `vpath` builds_
https://github.com/citusdata/the-process/blob/be26e475313e39e96f6380872f0e9cc7cb38b6db/circleci/images/debbuilder/files/build-pgdebs#L69-L71
* _Add the isolation tester to installed files_
https://github.com/citusdata/the-process/blob/be26e475313e39e96f6380872f0e9cc7cb38b6db/circleci/images/debbuilder/files/build-pgdebs#L81-L85
The `vpath` issue is actually a bug upstream and should be reported.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.