citusdata / citusdata/test-automation
Fabfile: || true commands
- Dominant language
- C
- Stars
- 15
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
In what cases do the `|| true` commands bring any benefit? If a command fails, we should fail. This prevents us from seeing what the actual issue is. We should remove all `|| true` commands and handle the different scenarios correctly.
Contributor guide
No contributing guide indexed for this repository
Research direction
Inspect the Fabfile and locate every command using `|| true`; first determine which failures are being suppressed and what scenarios each command is intended to handle. Run the relevant test-automation commands while removing the suppression, and consider the work done when failures are visible and each affected scenario is handled explicitly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing, tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100