citusdata / citusdata/postgresql-topn
Test fail
- Dominant language
- C
- Stars
- 249
- Forks
- 27
- PR merge metrics
- No merged PRs in 30d
Description
Hello:
when I test this extension with command make installcheck,ERROR named desired number of counters is higher than the topn.number_of_counters variable happened, just like blow:
test add_agg ... ok 427 ms
test union_agg ... ok 235 ms
test char_tests ... FAILED 44 ms
test null_tests ... ok 23 ms
test add_union_tests ... FAILED 77 ms
test copy_data ... ok 2254 ms
test customer_reviews_query ... ok 1840 ms
test join_tests ... FAILED 819 ms
information in char_tests.out:
SELECT (topn(topn_union_agg(jsonb_column), 9)).*
FROM jsonb_table;
- item | frequency
--------------------------------------+-----------
- TR | 6
- CH | 4
- US | 4
- FRA | 2
- ' | 1
- '"" +++--- <>?//#$%^&*()_+!@/t | 1
- \\\ | 1
- '"" | 1
- """"" | 1
-(9 rows)
-
**+ERROR: desired number of counters is higher than the topn.number_of_counters variable**
do
$$
declare
@@ -91,19 +79,7 @@
FROM values_table;
SELECT (topn(topn_union_agg(jsonb_column), 9)).*
FROM jsonb_table;
- item | frequency
---------------+-----------
- кйльжзхцвбнм | 35
- эасдфгч | 30
- тыуио | 20
- пющ | 12
- ёъяшер | 10
- TR | 9
- CH | 6
- US | 6
- FRA | 3
-(9 rows)
-
**+ERROR: desired number of counters is higher than the topn.number_of_counters variable**
do
$$
declare
I find this error in function topn in topn.c,what confuses me is why SRF_IS_FIRSTCALL() is always true.
Hope for your help.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reproducing the failures with make installcheck and review the char_tests, add_union_tests, and join_tests output. Then inspect the topn function in topn.c, focusing on why SRF_IS_FIRSTCALL() is always true and how that leads to the counter error. Done means identifying the cause and making the affected installcheck tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, postgresql
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100