citusdata / citusdata/citus

Excess quoting in test: changes meaning of search_path

Open
#7,951 0 comments 0 reactions 0 assignees View on GitHub
regression tests
Dominant language
C
Stars
12.8k
Forks
794
Avg merge
2d 14h
Merged PRs (30d)
31

Description

See https://github.com/pgaudit/pgaudit/pull/260 for a report against another
project using syntax `SET search_path = 'pg_catalog, pg_temp'`. A search of
PGXN for `'pg_catalog,` turned up one match in a citus test. While this is
benign in a testing context, I recommend making a change like that pull
request made. This would be a security vulnerability if used in non-test,
production code. Correcting the test code reduces the chance of someone
copying a bad pattern into non-test code.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.