citusdata / citusdata/citus

Consider propagating GRANTs for the database where Citus is installed too

Open
#7,358 0 comments 1 reaction 1 assignee Claimed by @gurkanindibay View on GitHub
bug DDL
Dominant language
C
Stars
12.8k
Forks
794
Avg merge
2d 14h
Merged PRs (30d)
31

Description

With https://github.com/citusdata/citus/pull/7240, we expanded our DDL support to support propagating CREATE / DROP DATABASE commands as well as the GRANTs on those distributed databases.

However, for the database where Citus is installed, we're only propagating its owner in case of node-activation instead of sending a CREATE DATABASE command for it because it must already exist on all other nodes. Otherwise, Citus wouldn't be operational anyway.

However, we should also consider whether we need to propagate GRANTs for the database where Citus is installed, in addition to propagating its owner, in case of node activation.

See OCLASS_DATABASE in GetDependencyCreateDDLCommands().

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.