citusdata / citusdata/citus

row order changed in case drop_column_partitioned_table between make checks

Open
#5,784 1 comment 0 reactions 0 assignees View on GitHub
regression tests
Dominant language
C
Stars
12.8k
Forks
794
Avg merge
2d 14h
Merged PRs (30d)
31

Description

pg-13.3, citus-v10.2.3
```diff
--- /home/xxx/sources/postgresql-13.3/contrib/citus/src/test/regress/expected/drop_column_partitioned_table.out.modified 2022-03-10 19:25:58.554239727 +0800
+++ /home/xxx/sources/postgresql-13.3/contrib/citus/src/test/regress/results/drop_column_partitioned_table.out.modified 2022-03-10 19:25:58.584239916 +0800
@@ -149,26 +149,26 @@
sensors_2001_shardid AS (SELECT * FROM get_shard_id_for_distribution_column('sensors_2001', 3)),
sensors_2002_shardid AS (SELECT * FROM get_shard_id_for_distribution_column('sensors_2002', 3)),
sensors_2003_shardid AS (SELECT * FROM get_shard_id_for_distribution_column('sensors_2003', 3)),
sensors_2004_shardid AS (SELECT * FROM get_shard_id_for_distribution_column('sensors_2004', 3)),
all_shardids AS (SELECT * FROM sensors_shardid UNION SELECT * FROM sensors_2000_shardid UNION
SELECT * FROM sensors_2001_shardid UNION SELECT * FROM sensors_2002_shardid
UNION SELECT * FROM sensors_2003_shardid UNION SELECT * FROM sensors_2004_shardid)
SELECT logicalrelid, shardid, shardminvalue, shardmaxvalue FROM pg_dist_shard WHERE shardid IN (SELECT * FROM all_shardids);
logicalrelid | shardid | shardminvalue | shardmaxvalue
--------------+---------+---------------+---------------
- sensors | 2580001 | -1073741824 | -1
- sensors_2000 | 2580005 | -1073741824 | -1
sensors_2001 | 2580009 | -1073741824 | -1
sensors_2002 | 2580013 | -1073741824 | -1
- sensors_2003 | 2580017 | -1073741824 | -1
+ sensors_2000 | 2580005 | -1073741824 | -1
+ sensors | 2580001 | -1073741824 | -1
sensors_2004 | 2580025 | -1073741824 | -1
+ sensors_2003 | 2580017 | -1073741824 | -1
(6 rows)

VACUUM ANALYZE sensors, sensors_2000, sensors_2001, sensors_2002, sensors_2003;
-- show that both INSERT and SELECT can route to a single node when distribution
-- key is provided in the query
EXPLAIN (COSTS FALSE) INSERT INTO sensors VALUES (3, '2000-02-02', row_to_json(row(1)));
QUERY PLAN
-----------------------------------------------------------
Custom Scan (Citus Adaptive)
Task Count: 1

```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.