citusdata / citusdata/citus

UnmarkObjectDistributed calls in utility hook may be obsolete

Open
#5,614 0 comments 0 reactions 0 assignees View on GitHub
technical debt
Dominant language
C
Stars
12.8k
Forks
794
Avg merge
2d 14h
Merged PRs (30d)
31

Description

For various DROP commands (e.g. DROP TYPE, DROP COLLATION, DROP SERVER), we have logic to extract the distributed objects from the statement and call UnmarkObjectDistributed.

However, we already call master_unmark_object_distributed via citus_drop_trigger, which also calls UnmarkObjectDistributed from the standard process utility function. That is more correct, since that also works in scenarios like DROP SCHEMA .. CASCADE.

Hence, the UnmarkObjectDistributed calls in the utility hook seem obsolete.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.