citusdata / citusdata/citus

Should we use a new connection while moving shards

Open
#4,971 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
12.8k
Forks
794
Avg merge
2d 14h
Merged PRs (30d)
31

Description

Currently we force a new connection for each colocated shard move but this might not be necessary, we should think about this and possibly re-use the same connections so that we don't get an error while opening a new connection. See the comment: https://github.com/citusdata/citus/pull/4967#pullrequestreview-655422852

Contributor guide

Open the contributing guide

Research direction

Start with the linked review comment on pull request 4967 and trace the code responsible for moving colocated shards and opening connections. Determine whether connection reuse is safe and what error the current behavior causes; done requires a decided approach and corresponding validation for shard moves.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, postgresql
Domain
databases, distributed-systems
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.