citusdata / citusdata/citus

Usage of Assert(False)

Open
#3,845 4 comments 0 reactions 0 assignees View on GitHub
development
Dominant language
C
Stars
12.8k
Forks
794
Avg merge
2d 14h
Merged PRs (30d)
31

Description

I personally feel like `Assert(false)` is not a good practice. The places where we use `Assert(false)` are illegal states. So maybe erroring with `IllegalStateError` seems a better practice to me. If you think `Assert(false)` is better than erroring, could you explain why in this issue?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.