citusdata / citusdata/citus

Move all qualifying logic in deparse* funcs to qualify* funcs

Open
#3,080 0 comments 0 reactions 0 assignees View on GitHub
technical debt
Dominant language
C
Stars
12.8k
Forks
794
Avg merge
2d 14h
Merged PRs (30d)
31

Description

When deparsing `{ALTER|DROP} .. {FUNCTION|PROCEDURE}` queries, we qualify the function/procedure and parameter type names. This logic should be implemented in `Qualify*FunctionStmt()` functions.

As @onderkalaci suggested today, `regprocedureout` can be handy in solving this
https://github.com/citusdata/citus/blob/bffd1104464127690864ea6034399e908aee7aa7/src/backend/distributed/commands/function.c#L622-L627

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.