Consider using text for LOCKMODEs in UDFs
Open
1-2 days
- Dominant language
- C
- Stars
- 12.8k
- Forks
- 794
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 31
Description
We've some `UDF`s such as `lock_shard_metadata` or `lock_shard_resources` which takes `int` as the `LOCKMODE` paremeter.
As @marcocitus mentioned [here](https://github.com/citusdata/citus/pull/2370/files#r216034658), using `text` instead of `integer` could be safer for rolling upgrades. For PG 11, @mtuncer will manually check that the lockmode integer haven't changed.
Using text also increases the readibility of `UDF`s.
We'll be keeping this issue open for reference.
Contributor guide
Assessment
This issue has not been assessed yet.