citusdata / citusdata/citus

Audit catalog table Datum conversions

Open
#2,208 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
12.8k
Forks
794
Avg merge
2d 14h
Merged PRs (30d)
31

Description

A long while back (#408), we found that we were accessing a 64-bit column using 32-bit methods. I'm pretty sure we've added more places we're doing this (nodeid, groupid seem suspicious). Some sort of tooling should be able to catch this (I imagine some sort of assert-only function call against a `TupleDesc`), but for the immediate future it would be good to look over places in our code that access such types and make sure they're always unmarshaled correctly.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.