citusdata / citusdata/citus

Regression tests: Change master_create_* calls with create_distributed_table

Open
#1,908 1 comment 0 reactions 0 assignees View on GitHub
1-2 days regression tests
Dominant language
C
Stars
12.8k
Forks
794
Avg merge
2d 14h
Merged PRs (30d)
31

Description

In Citus 6.0, we changed our table creation APIs. Customers would previously call `master_create_distributed_table()` and `master_create_worker_shards()` to create distributed tables. We deprecated these APIs in favor of `create_distributed_table()`.

We still use the deprecated APIs in 54 regression tests. We should update these regressions to the new APIs. We found that the old APIs fall into three groups:

- [ ] Creating hash distributed tables
- [ ] Creating append distributed tables (no `master_create_worker_shards`)
- [ ] Creating range distributed tables

As we are converting the old APIs, we should pay attention to the shard count and replication factor settings. Today, we set the replication factor through a GUC.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.