citusdata / citusdata/citus

shardid types are inconsistent across different usages

Open
#1,849 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
12.8k
Forks
794
Avg merge
2d 14h
Merged PRs (30d)
31

Description

We mostly consider shardid of type uint64, however some structs (i.e. ```ShardConnections```) use int64 for that.

It does not cause immediate problem, but we should standardize the way.
@jasonmp85 [suggested](https://github.com/citusdata/citus/pull/1831#discussion_r153863192) that we should use int64

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.