citusdata / citusdata/citus

Increase shard count in selected regression tests to reflect real-world usage

Open
#1,828 3 comments 0 reactions 0 assignees View on GitHub
1-2 days
Dominant language
C
Stars
12.8k
Forks
794
Avg merge
2d 14h
Merged PRs (30d)
31

Description

(edited)

We used to run most of our regression tests with the default shard count. We recently reduced the shard count number from 32 to 4. This change speeded up our regression tests, but might have reduced coverage for certain code paths.

@furkansahin and @ozgune chatted yesterday. We decided to make two changes to mitigate this:

1. Add (or change) a regression to test a scenario where Citus has ~100 shards. This is to mitigate the issue [@mtuncer found](https://github.com/citusdata/citus/issues/1828#issuecomment-353928507) in Windows, where we can't have reliably open more than 64 connections.
2. Change 3-4 regression tests and increase these tests' shard count back to 32. Customers start using Citus today with a shard count of 32. We'd like our regression tests to cover more of the default customer experience scenario. If we have regression tests that reflect the tutorials in our website, those could be good candidates for increased shard count.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.