citusdata / citusdata/citus

Citus continues sending commands to workers which have failed

Open
#1,173 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C
Stars
12.8k
Forks
794
Avg merge
2d 14h
Merged PRs (30d)
31

Description

All the connection functions which send commands do not check whether the connection is in a failed state before sending the command. This means that if we send a `BEGIN` in `StartRemoteTransactionBegin` which fails, for instance, later functions will continue to try sending commands to the remote node. If the failure was just temporary this could lead to big problems!

Example here: https://github.com/citusdata/citus/pull/1169/files#diff-59c96442a9866224ac2cfe12cc457f37R2071

Discussion here: https://github.com/citusdata/citus/pull/1169/files#r97957740

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.