citusdata / citusdata/citus

Allow StartPlacementConnection() to error out on invalid placementId

Open
#1,140 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
12.8k
Forks
794
Avg merge
2d 14h
Merged PRs (30d)
31

Description

#1133 / #1138 showed it'd be useful if StartPlacementConnection() asserted if an invalid placement id were specified. Unfortunately that's not possible right now, because the fake task router planner generates for shardless queries, use a fake placement.

There's various possible fixes to this:
- don't generate fake task placements, just allow task-less queries
- use a node connection for placement-less queries
- continue like now
- ?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.